Don't treat non-URL CodeRef modules as URLs #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemelia
force-pushed
the
code-ref-modules
branch
2 times, most recently
from
c43990b to
28bcb86
Compare
- adds commands field to SkillCard to exercise this
lukemelia
force-pushed
the
code-ref-modules
branch
from
28bcb86 to
6e1ea0e
Compare
habdelra
reviewed
Feb 24, 2025
habdelra
reviewed
Feb 24, 2025
habdelra
reviewed
Feb 24, 2025
habdelra
reviewed
Feb 24, 2025
habdelra
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue I ran into is that a recent change assumed that a CodeRef's module would always be a URL. However, ours can be something like: @cardstack/boxel-host/commands/create-ai-assistant-room
This PR above accommodates this while retaining the relative URL behavior change.